Repository navigation
Project import generated by Copybara. - #1551
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for Post-Quantum Cryptography (PQC) Key Encapsulation Mechanisms (KEM) and Key Derivation Functions (KDF), specifically implementing ML-KEM and HKDF algorithms, alongside utilities for Merkle Tree Certificates (MTC) verification. The review feedback highlights a memory leak in 'native_crypto.cc' where an allocated 'stack' is not freed upon an early return, and missing imports for 'urllib.request' and 'base64' in 'export_to_ag.py' that will cause runtime errors. Additionally, several defensive null checks are recommended in 'MtcUtils' to prevent potential NullPointerExceptions and improve error handling.
875c276 to
afb5498
Compare
PiperOrigin-RevId: 999963432
afb5498 to
f29a7f0
Compare
inorick
left a comment
inorick
left a comment
There was a problem hiding this comment.
Unmodified sync from google3.
3 participants
PiperOrigin-RevId: 999324197